Fix pivot basic rewrite with new PyZX version #334
Conversation
|
some debugging points at https://github.com/zxcalc/pyzx/blob/d81356b656ace618f4112266595d63415ac35dee/pyzx/rules.py#L683 check |
|
@colltoaction Do you expect you will continue to work on this? Otherwise I'm gonna close it. |
Traceback (most recent call last):
File "/home/mcoll/repos/github.com/colltoaction/zxlive/zxlive/rewrite_action.py", line 281, in do_rewrite
node.rewrite_action.do_rewrite(self.proof_panel)
File "/home/mcoll/repos/github.com/colltoaction/zxlive/zxlive/rewrite_action.py", line 114, in do_rewrite
g, rem_verts = self.apply_rewrite(g, matches)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/mcoll/repos/github.com/colltoaction/zxlive/zxlive/rewrite_action.py", line 129, in apply_rewrite
etab, rem_verts, rem_edges, check_isolated_vertices = self.rule(g, matches)
^^^^^^^^^^^^^^^^^^^^^
File "/home/mcoll/repos/github.com/colltoaction/zxlive/zxlive/rewrite_data.py", line 117, in rule
simplification(g)
File "/home/mcoll/.local/lib/python3.11/site-packages/pyzx/simplify.py", line 109, in pivot_simp
return simp(g, 'pivot_simp', match_pivot_parallel, pivot, matchf=matchf, quiet=quiet, stats=stats)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/mcoll/.local/lib/python3.11/site-packages/pyzx/simplify.py", line 98, in simp
g.remove_edges(rem_edges)
File "/home/mcoll/.local/lib/python3.11/site-packages/pyzx/graph/multigraph.py", line 237, in remove_edges
self.remove_edge(e)
File "/home/mcoll/.local/lib/python3.11/site-packages/pyzx/graph/multigraph.py", line 240, in remove_edge
s,t,ty = edge
^^^^^^
ValueError: not enough values to unpack (expected 3, got 2)
colltoaction
force-pushed
the
fix-pivot-256
branch
from
e43afd0 to
362844c
Compare
|
Hi @jvdwetering! I just took another look at the issue. I changed the rule so that it uses
Does it look in accordance to #256 (comment) to you? |
|
What was the graph that you started with? That one is not semantically equivalent to #256 (comment) |
|
|
With the current version of ZXLive I get: |
|
In your current implementation with |
This draft uncovers the issue with pivoting which I will solve next. cc @RazinShaikh. #256